| 1 |
On 23:52 Tue 25 Nov , Peter Alfredsen (loki_val) wrote: |
| 2 |
> loki_val 08/11/25 23:52:04 |
| 3 |
> |
| 4 |
> Added: gtk-sharp-module.eclass |
| 5 |
> Log: |
| 6 |
> eclass required for gnome-sharp and gnome-desktop-sharp packages |
| 7 |
|
| 8 |
Did I miss this on gentoo-dev? All eclasses must be sent there for |
| 9 |
review before addition to the tree. |
| 10 |
|
| 11 |
> if [[ " ${gtk_sharp_module_list} " == *" ${GTK_SHARP_MODULE} "* ]] ; then |
| 12 |
> my_module_list="${gtk_sharp_module_list}" |
| 13 |
> my_tarball="gtk-sharp" |
| 14 |
> elif [[ " ${gnome_sharp_module_list} " == *" ${GTK_SHARP_MODULE} "* ]] ; then |
| 15 |
|
| 16 |
This seems like a really strange strategy for checking whether a certain |
| 17 |
item is in a list. |
| 18 |
|
| 19 |
> # Make selecting components configurable. |
| 20 |
> epatch ${WORKDIR}/${MY_P}-configurable.diff |
| 21 |
|
| 22 |
This seems like something you might want optional, depending on some |
| 23 |
variable. |
| 24 |
|
| 25 |
> # Fixes support with pkgconfig-0.17, #92503. |
| 26 |
> sed -i -e 's/\<PKG_PATH\>/GTK_SHARP_PKG_PATH/g' \ |
| 27 |
> -e ':^CFLAGS=:d' \ |
| 28 |
> ${S}/configure.in |
| 29 |
|
| 30 |
It would be nice to quote all instances of $S, $D etc. |
| 31 |
|
| 32 |
> LANG=C emake -j1 || die "emake failed" |
| 33 |
|
| 34 |
Worth a comment about parallel make being broken, with a reference to |
| 35 |
the upstream bug. |
| 36 |
|
| 37 |
-- |
| 38 |
Thanks, |
| 39 |
Donnie |
| 40 |
|
| 41 |
Donnie Berkholz |
| 42 |
Developer, Gentoo Linux |
| 43 |
Blog: http://dberkholz.wordpress.com |
Archives