Archives
Archives
| From: | Mike Gilbert <floppym@g.o> | ||
|---|---|---|---|
| To: | Gentoo Dev <gentoo-dev@l.g.o> | ||
| Subject: | Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Document variables, minor style clean-up | ||
| Date: | Fri, 18 Feb 2022 18:57:56 | ||
| Message-Id: | CAJ0EP41u-88Na9oq57X63j6qG1S2A0QxZB=Wgi4py5MWpjr5Sw@mail.gmail.com | ||
| In Reply to: | [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Document variables, minor style clean-up by Mike Pagano |
||
| 1 | On Fri, Feb 18, 2022 at 1:01 PM Mike Pagano <mpagano@g.o> wrote: |
| 2 | > |
| 3 | > Document variables in the eclass, reorder alphabetically. |
| 4 | > Make spacing consistent in comment lines. |
| 5 | |
| 6 | For review purposes, I wish you had split this into two commits: one |
| 7 | to reorder/reformat the existing vars, and one to add the new ones. |
| 8 | |
| 9 | Anyway, I think the kernel version vars (KV_*) should be tagged with |
| 10 | @OUTPUT_VARIABLE. |