Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH] gnome2-utils.eclass: Fix the documentation for cache update functions
Date: Fri, 09 Feb 2018 09:42:30
Message-Id: 20180209094215.21195-1-mgorny@gentoo.org
1 Fix the documentation for recently changed cache update functions that
2 no longer rely on their _savelist() counterpart to indicate that.
3 ---
4 eclass/gnome2-utils.eclass | 12 +++++++-----
5 1 file changed, 7 insertions(+), 5 deletions(-)
6
7 diff --git a/eclass/gnome2-utils.eclass b/eclass/gnome2-utils.eclass
8 index 9b4296c11fad..65076ae2d61e 100644
9 --- a/eclass/gnome2-utils.eclass
10 +++ b/eclass/gnome2-utils.eclass
11 @@ -207,7 +207,9 @@ gnome2_gconf_uninstall() {
12 # @FUNCTION: gnome2_icon_savelist
13 # @DESCRIPTION:
14 # Find the icons that are about to be installed and save their location
15 -# in the GNOME2_ECLASS_ICONS environment variable.
16 +# in the GNOME2_ECLASS_ICONS environment variable. This is only
17 +# necessary for eclass implementations that call
18 +# gnome2_icon_cache_update conditionally.
19 # This function should be called from pkg_preinst.
20 gnome2_icon_savelist() {
21 has ${EAPI:-0} 0 1 2 && ! use prefix && ED="${D}"
22 @@ -218,8 +220,7 @@ gnome2_icon_savelist() {
23
24 # @FUNCTION: gnome2_icon_cache_update
25 # @DESCRIPTION:
26 -# Updates Gtk+ icon cache files under /usr/share/icons if the current ebuild
27 -# have installed anything under that location.
28 +# Updates Gtk+ icon cache files under /usr/share/icons.
29 # This function should be called from pkg_postinst and pkg_postrm.
30 gnome2_icon_cache_update() {
31 has ${EAPI:-0} 0 1 2 && ! use prefix && EROOT="${ROOT}"
32 @@ -358,7 +359,8 @@ gnome2_scrollkeeper_update() {
33 # @FUNCTION: gnome2_schemas_savelist
34 # @DESCRIPTION:
35 # Find if there is any GSettings schema to install and save the list in
36 -# GNOME2_ECLASS_GLIB_SCHEMAS variable.
37 +# GNOME2_ECLASS_GLIB_SCHEMAS variable. This is only necessary for eclass
38 +# implementations that call gnome2_schemas_update conditionally.
39 # This function should be called from pkg_preinst.
40 gnome2_schemas_savelist() {
41 has ${EAPI:-0} 0 1 2 && ! use prefix && ED="${D}"
42 @@ -370,7 +372,7 @@ gnome2_schemas_savelist() {
43 # @FUNCTION: gnome2_schemas_update
44 # @USAGE: gnome2_schemas_update
45 # @DESCRIPTION:
46 -# Updates GSettings schemas if GNOME2_ECLASS_GLIB_SCHEMAS has some.
47 +# Updates GSettings schemas.
48 # This function should be called from pkg_postinst and pkg_postrm.
49 gnome2_schemas_update() {
50 has ${EAPI:-0} 0 1 2 && ! use prefix && EROOT="${ROOT}"
51 --
52 2.16.1

Replies