Gentoo Archives: gentoo-dev

From: Joke Junkie <jjunkie@××××.li>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] [PATCH] waf-utils.eclass: WAF_VERBOSE always effectively on
Date: Wed, 15 Aug 2018 13:47:25
Message-Id: 20180814070354.GC17143@cock.li
1 Fix broken behavior not allowing to change the default verbosity.
2 This should be of importance to everybody building on SMP systems, since
3 giving the --verbose option to waf breaks a multi-job build (by making
4 it one-job), at least for me. This is probably a waf issue, but the
5 inability to change WAF_VERBOSE is clearly a bug in the eclass.
6 The test affected by change is always true because WAF_VERBOSE is always
7 set to "ON" or other non-null value. The change fixes that.
8 ---
9 eclass/waf-utils.eclass | 2 +-
10 1 file changed, 1 insertion(+), 1 deletion(-)
11
12 diff --git a/eclass/waf-utils.eclass b/eclass/waf-utils.eclass
13 index 7acc97b10314..8b011c04b400 100644
14 --- a/eclass/waf-utils.eclass
15 +++ b/eclass/waf-utils.eclass
16 @@ -98,7 +98,7 @@ waf-utils_src_configure() {
17 waf-utils_src_compile() {
18 debug-print-function ${FUNCNAME} "$@"
19 local _mywafconfig
20 - [[ "${WAF_VERBOSE}" ]] && _mywafconfig="--verbose"
21 + [[ "${WAF_VERBOSE}" = "ON" ]] && _mywafconfig="--verbose"
22
23 local jobs="--jobs=$(makeopts_jobs)"
24 echo "\"${WAF_BINARY}\" build ${_mywafconfig} ${jobs}"

Replies

Subject Author
Re: [gentoo-dev] [PATCH] waf-utils.eclass: WAF_VERBOSE always effectively on "M. J. Everitt" <m.j.everitt@×××.org>