Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check
Date: Mon, 02 Aug 2021 08:30:15
Message-Id: da4490c02430aadb1f403155b5f942d42b8f187e.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check by Georgy Yakovlev
1 On Mon, 2021-08-02 at 01:28 -0700, Georgy Yakovlev wrote:
2 > it can actually check if ebuild calls tmpfiles_process, not only
3 > inherit.
4 > something like:
5 >
6 >     local pkg_postinst_body="$(declare -fp pkg_postinst)"
7 >     if [[ ! ${pkg_postinst_body} == *tmpfiles_process* ]]; then
8 >         eqawarn "QA Notice: package is installing tmpfiles without
9 > calling
10 >         eqawarn "tmpfiles_process in pkg_postinst phase"
11 >     fi
12 >    
13 > ofc accounting for edge cases floppym mentioned.
14
15 This is going to cause false positives if tmpfiles_process is called via
16 another function.
17
18 --
19 Best regards,
20 Michał Górny

Replies