Re: [gentoo-dev] Re: [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable

[Zac Medico]

On Thu, May 4, 2017 at 10:29 PM, Michał Górny <mgorny@g.o> wrote:

> Dnia 4 maja 2017 22:34:56 CEST, Zac Medico <zmedico@g.o>
> napisał(a):
> >On Tue, May 2, 2017 at 2:48 PM, Zac Medico <zmedico@g.o> wrote:
> >
> >> This is intended to be set by the user when using ebuilds that may
> >> have unknown implementations in PYTHON_COMPAT. The assumption is
> >> that the ebuilds are intended to be used within multiple contexts
> >> which can involve revisions of this eclass that support different
> >> python implementations.
> >> ---
> >>  eclass/python-utils-r1.eclass | 16 ++++++++++++++++
> >>  1 file changed, 16 insertions(+)
> >>
> >> diff --git a/eclass/python-utils-r1.eclass
> >b/eclass/python-utils-r1.eclass
> >> index 66a359e..1846da3 100644
> >> --- a/eclass/python-utils-r1.eclass
> >> +++ b/eclass/python-utils-r1.eclass
> >> @@ -47,6 +47,21 @@ _PYTHON_ALL_IMPLS=(
> >>  )
> >>  readonly _PYTHON_ALL_IMPLS
> >>
> >> +# @ECLASS-VARIABLE: PYTHON_IMPLS_NO_STRICT
> >> +# @DESCRIPTION:
> >> +# Tolerate unknown implementations in PYTHON_COMPAT.
> >> +#
> >> +# This is intended to be set by the user when using ebuilds that may
> >> +# have unknown implementations in PYTHON_COMPAT. The assumption is
> >> +# that the ebuilds are intended to be used within multiple contexts
> >> +# which can involve revisions of this eclass that support different
> >> +# python implementations.
> >> +#
> >> +# Example:
> >> +# @CODE
> >> +# PYTHON_IMPLS_NO_STRICT=1
> >> +# @CODE
> >> +
> >>  # @FUNCTION: _python_impl_supported
> >>  # @USAGE: <impl>
> >>  # @INTERNAL
> >> @@ -79,6 +94,7 @@ _python_impl_supported() {
> >>                         fi
> >>                         ;;
> >>                 *)
> >> +                       [[ -n ${PYTHON_IMPLS_NO_STRICT} ]] && return
> >1
> >>                         die "Invalid implementation in PYTHON_COMPAT:
> >> ${impl}"
> >>         esac
> >>  }
> >> --
> >> 2.10.2
> >>
> >>
> >If nobody objects, I'd like to merge this sometime next week.
>
> If there's no explicit hurry, I'd like to commit it along with other
> python patch I'll be writing soon, to avoid multiple cache regens.
>

That works for me. Thank you!
-- 
Thanks,
Zac