Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Mike <mpagano@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH v3] linux-info.eclass : Support valid Make files
Date: Fri, 03 Sep 2021 09:06:58
Message-Id: ufsumt4db@gentoo.org
In Reply to: [gentoo-dev] [PATCH v3] linux-info.eclass : Support valid Make files by Mike
1 >>>>> On Fri, 03 Sep 2021, Mike wrote:
2
3 > - if [ ! -s "${KV_DIR}/Makefile" ]
4 > + get_makefile
5 > +
6 > + if [[ ! -s "${KERNEL_MAKEFILE}" ]]
7
8 <nitpick>
9 No quotation marks needed in [[ ]].
10 </nitpick
11
12 > + [[ -s "${KV_DIR}"/GNUMakefile ]] && KERNEL_MAKEFILE="${KV_DIR}/GNUMakefile"
13 > + [[ -s "${KV_DIR}"/makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/makefile"
14 > + [[ -s "${KV_DIR}"/Makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/Makefile"
15
16 Ditto.
17
18 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies