Re: [gentoo-dev] Re: All Developers!

[Mikael Hallendal]

sön 2001-11-11 klockan 13.39 skrev Martin Schlemmer:
> On Sun, 2001-11-11 at 14:27, Mikael Hallendal wrote:
> > lör 2001-11-10 klockan 22.04 skrev Daniel Robbins:
> > > On Sat, Nov 10, 2001 at 03:39:13PM -0500, Chris Houser wrote:
> > > > Daniel Robbins wrote:                 [Sat Nov 10 2001,  1:24:42PM EST]
> > > > > OK, if people need rules, I can provide them:
> > > > >
> > > > > 1) Use one tab per indent
> > > > >
> > > > > 2) Put comments on separate lines
> > > > >
> > > > > 3) Avoid using "/" line continuation characters and use long lines instead.
> > > >
> > > > Oh, please not 3) ... I realy dislike long lines.  I don't think it's
> > > > too big a deal if the line continuations don't line up for everybody.
> > >
> > > OK, I'll amend 3.  Either you can use long lines, or you can use "/" line
> > > continuation characters.  If you *do* use line continuation characters, you
> > > should *not* try to tab align them so that they're "pretty".  Instead, follow
> > > the line with a single space, then a "/", and then a newline.
> >
> > Hmm .. imho it's much easier to read with the \ aligned.
> > I think we can do this by supplying a emacs/vi-mode for editing ebuilds.
> > Those modes should be strict and force the developer to do it right.
> >
>
> Sure, but the problem just is: they do not align for different
> tabwidth's, so the emacs/vi-mode is not going to help much in
> that respect.  We either have to do it with only a space
> before the \, or all use a tabwidth of 4 as recommended by
> drobbins.
>
> Ill rather go for the space before the \ then, no offence to
> the 4 tabwidth guys ;)

I don't think there will be any problem making the emacs/vi-mode that
aligns the '\' with just one tab. Of course it won't look very good with
a non-emacs/vi editor but then it will look like 'foo \' will.

We should look on the ebuilds as source and not text-files. Just take a
look at emacs C-mode for example. When you hit TAB it aligns it
correctly, not 4 or 8 spaces. You set the indentwidth and so should we.

Ok, I'm a bit tired now so the above might be kinda hard to read but you
get the picture? :)

Regards,
  Mikael Hallendal

-- 

Mikael Hallendal
Gentoo Linux Developer, Desktop Team Leader
CodeFactory AB, Stockholm, Sweden