Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Mike Gilbert <floppym@g.o>
Cc: gentoo-dev@l.g.o, dist-kernel@g.o, base-system@g.o
Subject: Re: [gentoo-dev] [PATCH 1/8] dist-kernel-utils.eclass: support EAPI 8
Date: Thu, 08 Sep 2022 17:39:00
Message-Id: u5yhxu5p7@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/8] dist-kernel-utils.eclass: support EAPI 8 by Mike Gilbert
1 >>>>> On Thu, 08 Sep 2022, Mike Gilbert wrote:
2
3 > @@ -18,7 +18,7 @@ case "${EAPI:-0}" in
4 > 0|1|2|3|4|5|6)
5 > die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
6 > ;;
7 > - 7)
8 > + 7|8)
9 > ;;
10 > *)
11 > die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
12
13 While at it, maybe convert the conditional to the standard form in all
14 these eclasses? Like this:
15
16 case ${EAPI} in
17 7|8) ;;
18 *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
19 esac
20
21 I'd also drop EAPI 5 where it is applicable.

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies