[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: nvidia-driver.eclass

[Doug Goldstein]

On Sun, Nov 18, 2012 at 12:18 AM, Samuli Suominen <ssuominen@g.o> wrote:
> On 18/11/12 07:47, Doug Goldstein (cardoe) wrote:
>>
>> cardoe      12/11/18 05:47:02
>>
>>    Modified:             nvidia-driver.eclass
>>    Log:
>>    Update to support a new legacy series
>>
>> Revision  Changes    Path
>> 1.16                 eclass/nvidia-driver.eclass
>>
>> file :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/nvidia-driver.eclass?rev=1.16&view=markup
>> plain:
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/nvidia-driver.eclass?rev=1.16&content-type=text/plain
>> diff :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/nvidia-driver.eclass?r1=1.15&r2=1.16
>>
>> Index: nvidia-driver.eclass
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/eclass/nvidia-driver.eclass,v
>> retrieving revision 1.15
>> retrieving revision 1.16
>> diff -u -r1.15 -r1.16
>> --- nvidia-driver.eclass        22 Aug 2011 04:46:32 -0000      1.15
>> +++ nvidia-driver.eclass        18 Nov 2012 05:47:02 -0000      1.16
>> @@ -1,6 +1,6 @@
>>   # Copyright 1999-2011 Gentoo Foundation
>>   # Distributed under the terms of the GNU General Public License v2
>> -# $Header: /var/cvsroot/gentoo-x86/eclass/nvidia-driver.eclass,v 1.15
>> 2011/08/22 04:46:32 vapier Exp $
>> +# $Header: /var/cvsroot/gentoo-x86/eclass/nvidia-driver.eclass,v 1.16
>> 2012/11/18 05:47:02 cardoe Exp $
>>
>>   # @ECLASS: nvidia-driver.eclass
>>   # @MAINTAINER:
>> @@ -30,9 +30,21 @@
>>   031b 031c 0320 0321 0322 0323 0324 0325 0326 0327 0328 032a 032b 032c
>> 032d \
>>   0330 0331 0332 0333 0334 0338 033f 0341 0342 0343 0344 0347 0348 034c
>> 034e"
>>
>> +drv_304x="0040 0041 0042 0043 0044 0045 0046 0047 0048 004e 0090 0091
>> 0092 \
>> +0093 0095 0098 0099 009d 00c0 00c1 00c2 00c3 00c8 00c9 00cc 00cd 00ce
>> 00f1 \
>> +00f2 00f3 00f4 00f5 00f6 00f8 00f9 0140 0141 0142 0143 0144 0145 0146
>> 0147 \
>> +0148 0149 014a 014c 014d 014e 014f 0160 0161 0162 0163 0164 0165 0166
>> 0167 \
>> +0168 0169 016a 01d0 01d1 01d2 01d3 01d6 01d7 01d8 01da 01db 01dc 01dd
>> 01de \
>> +01de 01df 0211 0212 0215 0218 0221 0222 0240 0241 0242 0244 0245 0247
>> 0290 \
>> +0291 0292 0293 0294 0295 0297 0298 0299 029a 029b 029c 029d 029e 029f
>> 02e0 \
>> +02e1 02e2 02e3 02e4 038b 0390 0391 0392 0393 0394 0395 0397 0398 0399
>> 039c \
>> +039e 03d0 03d1 03d2 03d5 03d6 0531 0533 053a 053b 053e 07e0 07e1 07e2
>> 07e3 \
>> +07e5"
>> +
>>   mask_96xx=">=x11-drivers/nvidia-drivers-97.0.0"
>>   mask_71xx=">=x11-drivers/nvidia-drivers-72.0.0"
>>   mask_173x=">=x11-drivers/nvidia-drivers-177.0.0"
>> +mask_173x=">=x11-drivers/nvidia-drivers-305.0.0"
>
>
> I don't know the eclass, but shouldn't this say mask_304x here ?
>
>>
>>   # @FUNCTION: nvidia-driver-get-card
>>   # @DESCRIPTION:
>> @@ -71,6 +83,13 @@
>>                                 return 0;
>>                         fi
>>                 done
>> +
>> +               for drv in $drv_304x; do
>> +                       if [ "x$card" = "x$drv" ]; then
>> +                               echo "$mask_304x";
>> +                               return 0;
>> +                       fi
>> +               done
>>         done
>>
>>         echo "";
>>
>>
>>
>>
>

Thank you for finding the flaw in my mail filter rule to delete these
e-mails when they hit gentoo-dev, where I'm directly addressed. In the
future if you want these e-mails to go through you'll have to e-mail
me directly without CCing the list or sending it to the list. Just
doing my part to help clean up pointless e-mails to -dev one mail
filter at a time.

That said, you are actually correct.

-- 
Doug Goldstein