Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: dev-ruby/metasm/

[Davide Pesavento]

On Fri, Oct 9, 2015 at 5:35 PM, hasufell <hasufell@g.o> wrote:
> On 10/08/2015 11:04 PM, Richard Farina wrote:
>> commit:     f05eda22c275381c669e6f2a88dabd1356a3541f
>> Author:     Zero_Chaos <zerochaos <AT> gentoo <DOT> org>
>> AuthorDate: Thu Oct  8 20:45:33 2015 +0000
>> Commit:     Richard Farina <zerochaos <AT> gentoo <DOT> org>
>> CommitDate: Thu Oct  8 21:04:37 2015 +0000
>> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f05eda22
>>
>> dev-ruby/metasm: import from pentoo
>>
>> Package-Manager: portage-2.2.22
>>
>>  dev-ruby/metasm/Manifest               |  1 +
>>  dev-ruby/metasm/metadata.xml           | 10 +++++++
>>  dev-ruby/metasm/metasm-1.0.2-r1.ebuild | 52 ++++++++++++++++++++++++++++++++++
>>  3 files changed, 63 insertions(+)
>>
>
> [...]
>
>> --- /dev/null
>> +++ b/dev-ruby/metasm/metasm-1.0.2-r1.ebuild
>> @@ -0,0 +1,52 @@
>> +# Copyright 1999-2015 Gentoo Foundation
>> +# Distributed under the terms of the GNU General Public License v2
>> +# $Id$
>> +
>> +EAPI=5
>> +USE_RUBY="ruby19 ruby20 ruby21"
>> +
>> +inherit ruby-fakegem
>> +
>> +RUBY_FAKEGEM_EXTRAINSTALL="metasm metasm.rb misc samples"
>> +
>> +DESCRIPTION="cross-architecture assembler, disassembler, linker, and debugger"
>> +HOMEPAGE="http://metasm.cr0.org/"
>> +SRC_URI="mirror://rubygems/${P}.gem"
>> +
>> +LICENSE="BSD"
>> +SLOT="${PV}"
>> +KEYWORDS="~amd64 ~arm ~x86"
>> +#IUSE="development test"
>> +RESTRICT=test
>> +IUSE=""
>> +
>> +RDEPEND="${RDEPEND} !dev-ruby/metasploit-model:0"
>> +
>> +ruby_add_rdepend ">=dev-ruby/railties-4.0.9:4.0
>> +                     >=dev-ruby/activesupport-4.0.9:4.0
>> +                     >=dev-ruby/activemodel-4.0.9:4.0"
>> +ruby_add_bdepend "dev-ruby/bundler"
>> +
>> +all_ruby_prepare() {
>> +     [ -f Gemfile.lock ] && rm Gemfile.lock
>
> missing "|| die" afais, should probably be
>
> [ -f Gemfile.lock ] && { rm Gemfile.lock || die ; }
>

Or simply:

rm -f Gemfile.lock || die

>> +     #For now, we don't support development or testing at all
>> +     #if ! use development; then
>> +             sed -i -e "/^group :development do/,/^end$/d" Gemfile || die
>> +             sed -i -e "/s.add_development_dependency/d" "${PN}".gemspec || die
>> +             sed -i -e "/spec.add_development_dependency/d" "${PN}".gemspec || die
>> +     #fi
>> +     #if ! use test; then
>> +             sed -i -e "/^group :test do/,/^end$/d" Gemfile || die
>> +     #fi
>> +     #if ! use test && ! use development; then
>> +             sed -i -e "/^group :development, :test do/,/^end$/d" Gemfile || die
>> +     #fi
>> +}
>> +
>> +each_ruby_prepare() {
>> +     if [ -f Gemfile ]
>> +     then
>> +                     BUNDLE_GEMFILE=Gemfile ${RUBY} -S bundle install --local || die
>> +                     BUNDLE_GEMFILE=Gemfile ${RUBY} -S bundle check || die
>> +     fi
>> +}
>>
>
>