Gentoo Archives: gentoo-dev

From: Joshua Kinard <kumba@g.o>
To: Gentoo-dev <gentoo-dev@l.g.o>
Subject: [gentoo-dev] [PATCH] kernel-2.eclass: introduce K_FROM_GIT for sources that derive from git repos
Date: Sat, 20 Aug 2016 12:13:58
Message-Id: 40b687e0-4d53-9a84-aa05-dc34f72049a3@gentoo.org
1 All,
2
3 It looks like that sometime around Linux 3.15, some kind of a quirk was
4 introduced where a patch that contains the removal of a symlink followed by the
5 addition of a file with the same name as the symlink causes patch's --dry-run
6 phase to fail, which kills 'epatch'. See Bug #507656.
7
8 A workaround was added to kernel-2.eclass, around line 1093, that hardcodes a
9 check for sys-kernel/git-sources, to avoid this issue. Well,
10 sys-kernel/mips-sources is also affected by the same issue. I'm close to
11 releasing a newer mips-sources, having spent the last few months
12 re-writing/refactoring chunks of old SGI IP27/BRIDGE code, and rather than add
13 another hardcode to kernel-2, I instead created a new variable, K_FROM_GIT,
14 that will replace the hardcode.
15
16 When set to a value, it triggers the workaround, which still affects current
17 kernels. This results in a cleaner implementation instead of a hardcoded
18 ebuild, should future kernel packages sourced from a git repo get added.
19
20 Patch is attached for review.
21
22 Thanks!
23
24 --
25 Joshua Kinard
26 Gentoo/MIPS
27 kumba@g.o
28 6144R/F5C6C943 2015-04-27
29 177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943
30
31 "The past tempts us, the present confuses us, the future frightens us. And our
32 lives slip away, moment by moment, lost in that vast, terrible in-between."
33
34 --Emperor Turhan, Centauri Republic

Attachments

File name MIME type
kernel-2_eclass-from-git.diff text/x-patch

Replies