| 1 |
On Sat, 2019-03-02 at 18:41 -0500, Mike Gilbert wrote: |
| 2 |
> On Sat, Mar 2, 2019 at 5:10 PM Michał Górny <mgorny@g.o> wrote: |
| 3 |
> > On Sat, 2019-03-02 at 16:59 -0500, Mike Gilbert wrote: |
| 4 |
> > > On Mon, Feb 25, 2019 at 1:37 AM Ulrich Mueller <ulm@g.o> wrote: |
| 5 |
> > > > > > > > > On Wed, 20 Feb 2019, Michał Górny wrote: |
| 6 |
> > > > > On Wed, 2019-02-20 at 07:20 +0100, Ulrich Mueller wrote: |
| 7 |
> > > > > > > > > > > On Wed, 20 Feb 2019, Matt Turner wrote: |
| 8 |
> > > > > > > # Don't install libtool archives (even for modules) |
| 9 |
> > > > > > > - prune_libtool_files --all |
| 10 |
> > > > > > > + find "${D}" -name '*.la' -delete || die |
| 11 |
> > > > > > |
| 12 |
> > > > > > Maybe restrict removal to regular files, i.e. add "-type f"? |
| 13 |
> > > > > I suppose you should have spoken up when people started adopting that |
| 14 |
> > > > > 'find' line all over the place. Though I honestly doubt we're going |
| 15 |
> > > > > to see many packages installing '*.la' non-files. |
| 16 |
> > > > |
| 17 |
> > > > I have updated the example in ltprune.eclass now. |
| 18 |
> > > > |
| 19 |
> > > > That still won't catch regular non-libtool files, but people needing |
| 20 |
> > > > additional sanity checks can still use the eclass. |
| 21 |
> > > |
| 22 |
> > > Perhaps we should un-ban the ltprune eclass for EAPI 7? |
| 23 |
> > > |
| 24 |
> > > It seems like it would still be useful to have a way of detecting |
| 25 |
> > > libtool-archives instead of removing any file that ends with ".la". |
| 26 |
> > > |
| 27 |
> > |
| 28 |
> > How many valid cases for this are there? For comparison, how many |
| 29 |
> > useless complexity will be added to ebuilds by thoughtless maintainers |
| 30 |
> > using the first thing that seems to work without actually verifying |
| 31 |
> > whether it is necessary? |
| 32 |
> |
| 33 |
> As a maintainer, any time spent worrying about .la files is wasted |
| 34 |
> time. We have code that can figure it out automatically and allow me |
| 35 |
> to stop wasting brain power. |
| 36 |
> |
| 37 |
|
| 38 |
Do you have any estimates how much more time is wasted on verifying |
| 39 |
the result of find one-liner vs. verifying the result of complex |
| 40 |
function (which used to have false negatives)? Please note I'm talking |
| 41 |
about effort in case people are doing the right thing, not ignoring |
| 42 |
the problems with the function and assuming it will always work fine. |
| 43 |
|
| 44 |
-- |
| 45 |
Best regards, |
| 46 |
Michał Górny |
Archives