Gentoo Archives: gentoo-dev

From: Andrew Savchenko <bircoph@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] fortran-2.eclass: support EAPI 7
Date: Thu, 01 Nov 2018 22:28:51
Message-Id: 20181102012642.a7d615262c2d9cac6cb56960@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] fortran-2.eclass: support EAPI 7 by "Andreas K. Huettel"
1 Hi!
2
3 On Mon, 29 Oct 2018 23:52:31 +0100 Andreas K. Huettel wrote:
4 > >
5 > > -inherit eutils toolchain-funcs
6 > > +inherit toolchain-funcs
7 > >
8 > > case ${EAPI:-0} in
9 > > - 4|5|6) EXPORT_FUNCTIONS pkg_setup ;;
10 > > + 4|5|6|7) EXPORT_FUNCTIONS pkg_setup ;;
11 > > *) die "EAPI=${EAPI} is not supported" ;;
12 > > esac
13 > >
14 >
15 > ^ The disadvantage of this is that eutils inheritance then suddenly disappears
16 > for all ebuilds. And you don't know who assumed implicitly somewhere that
17 > inheriting fortran-2 makes epatch available...
18 >
19 > So how about still inheriting eutils for EAPI 4,5,6 and only dropping it for
20 > EAPI 7 ?!
21
22 I agree, backward compatibility matters. Fixed in v2 patch.
23
24
25 Best regards,
26 Andrew Savchenko