Gentoo Archives: gentoo-dev

From: Sergei Trofimovich <slyfox@g.o>
To: Joshua Kinard <kumba@g.o>, toolchain@g.o
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] toolchain.eclass: Remove kludge that blocks gcc-6+ on sys-libs/uclibc-ng systems
Date: Sun, 30 Jul 2017 07:46:33
Message-Id: 20170730084615.37fa1900@sf
In Reply to: [gentoo-dev] [PATCH] toolchain.eclass: Remove kludge that blocks gcc-6+ on sys-libs/uclibc-ng systems by Joshua Kinard
1 On Sat, 29 Jul 2017 19:12:23 -0400
2 Joshua Kinard <kumba@g.o> wrote:
3
4 > The following kludge is present in toolchain.eclass, in
5 > toolchain_pkg_pretend():
6 >
7 > [[ -z ${UCLIBC_VER} ]] && [[ ${CTARGET} == *-uclibc* ]] && \
8 > die "Sorry, this version does not support uClibc"
9 >
10 > The below patch removes this. I've been running a gcc-6-built,
11 > sys-libs/uclibc-ng in chroot for some time now, have completed several
12 > catalyst runs, and am at the tail end of a fresh install of a
13 > sys-libs/uclibc-ng userland on actual MIPS hardware.
14 >
15 > Signed-off-by: Joshua Kinard <kumba@g.o>
16 > ---
17 > eclass/toolchain.eclass | 3 ---
18 > 1 file changed, 3 deletions(-)
19 >
20 > --- a/eclass/toolchain.eclass.orig 2017-07-29 19:06:30.894211203 -0400
21 > +++ b/eclass/toolchain.eclass 2017-07-29 19:06:40.514211133 -0400
22 > @@ -375,9 +375,6 @@ toolchain_pkg_pretend() {
23 > "in your make.conf if you want to use this version."
24 > fi
25 >
26 > - [[ -z ${UCLIBC_VER} ]] && [[ ${CTARGET} == *-uclibc* ]] && \
27 > - die "Sorry, this version does not support uClibc"
28 > -
29 > if ! use_if_iuse cxx ; then
30 > use_if_iuse go && ewarn 'Go requires a C++ compiler, disabled due to USE="-cxx"'
31 > use_if_iuse objc++ && ewarn 'Obj-C++ requires a C++ compiler, disabled due to USE="-cxx"'
32 >
33 >
34
35 [ CCed toolchain@ as maintainer ]
36
37 Looks good.
38
39 --
40
41 Sergei

Replies