Gentoo Archives: gentoo-dev

From: Georgi Georgiev <chutz@×××.net>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [Package split] Split of mga_vid mplayer module from mplayer
Date: Fri, 16 Jul 2004 15:18:35
Message-Id: 20040716151828.GA1228@lion.gg3.net
In Reply to: [gentoo-dev] [Package split] Split of mga_vid mplayer module from mplayer by Chris White
1 maillog: 16/07/2004-03:36:24(+0900): Chris White types
2 > 2) tarballing the mga driver directory and placing it on the mirrors
3 > with the same release version as the mplayer it was packaged from
4
5 I agree with the other two replies to this thread regarding this point.
6
7 > OR
8 >
9 > downloading mplayer and simply building the mga driver folder.
10
11 Oh, yes. That's the one I want.
12
13 One point I think is worth mentioning: we do not need all the magic in the
14 mplayer-provided Makefile, and therefore all the trouble that comes with it.
15 Most of the problems that we get are because there are three possible scenarios
16 for the kernel, that are hard to take care of upstream:
17
18 2.4.x, 2.6.x, 2.6.x + KOUTPUT
19
20 and nobody upstream is expected to care about KOUTPUT, which is something very
21 gentoo-specific and which seems to be the cause for most of the trouble.
22
23 So, instead of duplicating effort in the Makefile and trying to figure the
24 kernel version twice, why not do it once in the ebuild using some nice portage
25 function (already implemented), and then simply overwrite the Makefile with a
26 version appropriate for the kernel version.
27
28 I have mentioned this on http://bugs.gentoo.org/show_bug.cgi?id=28846 as well,
29 but what I do in the mga_vid ebuild in my overlay, is to overwrite the Makefile
30 with the one quoted below if there is a 2.6 kernel present. (I don't really
31 check the kernel version, because this is my *personal* overlay, but the change
32 is trivial).
33
34 === Makefile-2.6 ===
35 obj-m += mga_vid.o
36
37 all: mga_vid.ko
38
39 %.ko: %.c %.h
40 $(MAKE) -C /usr/src/linux SUBDIRS=$(PWD) modules
41
42 install:
43 $(MAKE) -C /usr/src/linux SUBDIRS=$(PWD) modules_install
44 === EOF ===
45
46 The above compiles the module just fine on *any* 2.6.x kernel.
47
48 Ah, we don't even the install target.
49
50 --
51 > Georgi Georgiev > Immature poets imitate, mature poets >
52 < chutz@×××.net < steal. -- T.S. Eliot, "Philip Massinger" <
53 > +81(90)6266-1163 > >
54
55 --
56 gentoo-dev@g.o mailing list