[gentoo-dev] Re: sys-libs/ncurses: erronious deletion of *.dll.a files; possibly other packages affected

[Marty E. Plummer]

On Fri, Sep 29, 2017 at 08:29:07AM +0000, Michael Haubenwallner wrote:
> On 09/29/2017 03:36 AM, Marty E. Plummer wrote:
> > On Thu, Sep 28, 2017 at 07:35:20PM +0000, Mike Gilbert wrote:
> >> On Wed, Sep 20, 2017 at 10:01 PM, Marty E. Plummer
> >> <hanetzer@×××××××××.com> wrote:
> >>> arfrever suggests I send a mail here, as there are other packages which
> >>> may be affected by this issue and perhaps a more generalized fix is
> >>> required instead of an explicit fix in sys-libs/ncurses and other ebuilds
> >>> that may require it.
> >>
> >> I think the solution here is to remove those overly broad "find
> >> -delete" statements and replace them with something safer.
> >>
> >> Ideally the build system(s) would be patched to not compile static
> >> libs in the first place.
> >>
> >> If that's not possible, perhaps an eclass function could be created to
> >> safely remove static libs.
> >>
> > Honestly I already have a pr up that fixes this particular package's
> > issue, fairly simple fix https://github.com/gentoo/gentoo/pull/5734
> >
> > --- a/sys-libs/ncurses/ncurses-6.0-r1.ebuild
> > +++ b/sys-libs/ncurses/ncurses-6.0-r1.ebuild
> > @@ -241,7 +241,8 @@ multilib_src_install() {
> >  		# Provide a link for -lcurses.
> >  		ln -sf libncurses$(get_libname) "${ED}"/usr/$(get_libdir)/libcurses$(get_libname) || die
> >  	fi
> > -	use static-libs || find "${ED}"/usr/ -name '*.a' -delete
> > +	# don't delete '*.dll.a', needed for linking #631468
> > +	use static-libs || find "${ED}"/usr/ -name '*.a' ! -name '*.dll.a' -delete
>
> In prefix overlay we have this version:
>
>   use static-libs || find "${ED}"/usr/ -name '*.a' -not -name "*$(get_libname)" -delete
>
> /haubi/
Won't work here, as $(get_libname) returns .dll in this case, which is
why the symlinking is busted