1 |
On Tue, 11 Oct 2011 14:50:30 -0400 |
2 |
Matt Turner <mattst88@g.o> wrote: |
3 |
|
4 |
> On Tue, Oct 11, 2011 at 2:34 PM, Samuli Suominen |
5 |
> <ssuominen@g.o> wrote: |
6 |
> > I just hope nobody will take an example of the ebuild with code |
7 |
> > duplication (multiple epatch calls), overquoting, redudant use of |
8 |
> > find when rm is more than enough, ... |
9 |
> |
10 |
> I haven't looked, but if we don't already, a little style guide would |
11 |
> be very cool. I wouldn't think of most of these things without seeing |
12 |
> it somewhere else first. |
13 |
> |
14 |
> It looks like the epatch devmanual page uses multiple calls. :\ |
15 |
|
16 |
I don't think that passing multiple files to epatch actually improves |
17 |
readability. Simple example: |
18 |
|
19 |
# bug #123456, foo, bar |
20 |
epatch "${FILESDIR}"/${P}-foo.patch |
21 |
# bug #234567, baz bazinga blah blah |
22 |
epatch "${FILESDIR}"/${P}-baz.patch |
23 |
|
24 |
With multiple arguments, you can't put comments in the middle. |
25 |
|
26 |
-- |
27 |
Best regards, |
28 |
Michał Górny |