From: | Sergei Trofimovich <slyfox@g.o> | ||
---|---|---|---|
To: | gentoo-dev@l.g.o | ||
Subject: | [gentoo-dev] Re: [PATCH] epatch.eclass: drop 'estach.eclass' usage | ||
Date: | Sat, 18 Aug 2018 23:30:25 | ||
Message-Id: | 20180819003004.5a227066@sf | ||
In Reply to: | [gentoo-dev] [PATCH] epatch.eclass: drop 'estach.eclass' usage by Sergei Trofimovich |
1 | On Sat, 11 Aug 2018 01:02:23 +0100 |
2 | Sergei Trofimovich <slyfox@g.o> wrote: |
3 | |
4 | > Avoid use of eshopts_push / eshopts_pop functions |
5 | > as they don't preserve expand_aliases shell option |
6 | > and get detected by QA warning as: |
7 | > * QA Notice: Global shell options changed and were |
8 | > not restored while calling 'src_prepare' |
9 | > |
10 | > Ssee bug #662586 for details. |
11 | > |
12 | > Tested as: |
13 | > $ EPATCH_USER_EXCLUDE="*" ebuild gcc-8.2.0.ebuild clean prepare |
14 | > |
15 | > CC: mgorny@g.o |
16 | > CC: base-system@g.o |
17 | > Bug: https://bugs.gentoo.org/662586 |
18 | > Signed-off-by: Sergei Trofimovich <slyfox@g.o> |
19 | > --- |
20 | > eclass/epatch.eclass | 11 +++++------ |
21 | > 1 file changed, 5 insertions(+), 6 deletions(-) |
22 | |
23 | Pushed as: |
24 | https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b21e386a064e1ed49981d9527f968ddc5e1eeb86 |
25 | |
26 | -- |
27 | |
28 | Sergei |