Gentoo Archives: gentoo-dev

From: Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>
To: Gentoo Development <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] Re: Locale check in python_pkg_setup()
Date: Fri, 30 Jul 2010 02:31:39
Message-Id: 201007300432.18194.Arfrever@gentoo.org
In Reply to: [gentoo-dev] Re: Locale check in python_pkg_setup() by Jonathan Callen
1 2010-07-30 02:13:20 Jonathan Callen napisaƂ(a):
2 > On 07/29/2010 07:16 PM, Arfrever Frehtes Taifersar Arahesis wrote:
3 > > + locale="$(python -c 'import os; print(os.environ.get("LC_ALL", os.environ.get("LC_CTYPE", os.environ.get("LANG", "POSIX"))))')"
4 > > + if [[ "${locale}" != *.UTF-8 ]]; then
5 >
6 > Shouldn't you be checking the output of `locale charmap` instead of the
7 > actual contents of the LC_ALL/LC_CTYPE/LANG variables? You currently
8 > are reporting an error if someone is using the "en_US.utf8" locale
9 > (which *is* a legal UTF-8 locale, and should not be an error).
10
11 OK. I will check output of `locale charmap`, but the actual locale is more useful in error message.
12
13 --
14 Arfrever Frehtes Taifersar Arahesis

Attachments

File name MIME type
python.eclass.patch text/x-patch
signature.asc application/pgp-signature