Re: [gentoo-dev] RFC: emboss.eclass as replacement for embassy.eclass

[justin]

On 15/03/11 23:06, Mike Frysinger wrote:
>> # Copyright 1999-2004 Gentoo Foundation
>
> s/2004/2011/
>
> have you looked at the man page output for this to make sure the white spacing
> you're putting into the comments properly carries over ?

I will do this before the final commit. Currently it is alright.

>
>> # @ECLASS-VARIABLE: EBO_DESCRIPTION
>> # @DESCRIPTION:
>> # Should be set. Completes the describtion of the embassy module as follows:
>
> i dont understand what this is trying to say (ignoring the spelling mistake in
> description)

These are all modules for EMBOSS. I want to shorten the Description of
each ebuild to the important part. But I will makes this clearer for the
manpage. What I don't want, is what you can read in all the gstreamer
plugins "plugins for foo"

>> HOMEPAGE="http://emboss.sourceforge.net"
>
> could do with a trailing "/"

I asked myself quite often, if this needed or not. What is the purpose
of the trailing "/"?

//
snip
//

>> #  $(use_with png pngdriver "${EPREFIX}/usr")
>> #  $(use_with pdf hpdf "${EPREFIX}/usr")
>> #  $(use_with mysql mysql "${EPREFIX}/usr/bin/mysql_config")
>> #  $(use_with postgres postgresql "${EPREFIX}/usr/bin/pg_config")
>
> do you really need full paths here ?  are the configure scripts that screwed
> up ?  ideally libs would be found via .pc files.

It f..ing defaults to / roots if not specified

>
>> #  $(use_enable amd64 64)
>
> oh god it burns so bad when i poo
>
>> emboss_src_install() {
>> 	default
>> 	mv "${ED}"/usr/share/EMBOSS/doc/* "${ED}"/usr/share/doc/${PF}/
>> 	rm -rf "${ED}"/usr/share/EMBOSS/doc
>
> does the configure script respect --docdir= ?  then you wouldnt need this
> clean up logic ...

It soesn't and actually the java part (not installed yet) expects docs
here. I am not sure where this could be left like this or breaks somehting.

> -mike

Thanks mike for all your suggestions and remarks. I will fix the eclass
accordingly.

justin