| 1 |
On Wed, Sep 26, 2007 at 06:41:50AM +0000, Mike Frysinger (vapier) wrote: |
| 2 |
> - if [[ -f "${ROOT}/etc/conf.d/$1" ]]; then |
| 3 |
> + if [[ -f ${ROOT}/etc/conf.d/$1 ]]; then |
| 4 |
You removed the quotes here - $ROOT with spaces? |
| 5 |
> - [[ -e "${ROOT}etc/${x}" ]] && continue |
| 6 |
> - [[ -e "${ROOT}usr/share/baselayout/${x}" ]] || continue |
| 7 |
> - cp -p "${ROOT}usr/share/baselayout/${x}" ${ROOT}etc |
| 8 |
> + [[ -e ${ROOT}etc/${x} ]] && continue |
| 9 |
> + [[ -e ${ROOT}usr/share/baselayout/${x} ]] || continue |
| 10 |
> + cp -p "${ROOT}usr/share/baselayout/${x}" "${ROOT}"etc |
| 11 |
2 removes, one add. Make up your mind. |
| 12 |
|
| 13 |
> - for f in ${ROOT}etc/init.d/net.*; do |
| 14 |
> - [[ -L ${f} || ${f} == "${ROOT}etc/init.d/${lo}" ]] && continue |
| 15 |
> + for f in "${ROOT}"etc/init.d/net.*; do |
| 16 |
> + [[ -L ${f} || ${f} == */${lo} ]] && continue |
| 17 |
Again the quotes, and that conditional looks iffy, it was checking |
| 18 |
against ${ROOT}/etc/init.d/net.lo before, and now it's checking against |
| 19 |
${PWD}/*/net.lo? |
| 20 |
|
| 21 |
> - if [[ -e "${ROOT}"/etc/env.d/01hostname ]] ; then |
| 22 |
> + if [[ -e ${ROOT}/etc/env.d/01hostname ]] ; then |
| 23 |
... |
| 24 |
> - if [[ -e "${ROOT}"/etc/init.d/domainname ]] ; then |
| 25 |
> + if [[ -e ${ROOT}/etc/init.d/domainname ]] ; then |
| 26 |
Again with the quotes. |
| 27 |
|
| 28 |
-- |
| 29 |
Robin Hugh Johnson |
| 30 |
Gentoo Linux Developer & Infra Guy |
| 31 |
E-Mail : robbat2@g.o |
| 32 |
GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 |
Archives