1 |
On 30 Oct 2015 18:20, Michał Górny wrote: |
2 |
> On Fri, 30 Oct 2015 12:03:59 +0000 (UTC) "Justin Lecher" wrote: |
3 |
> > commit: df8e399c9bac2dc30d7cf69c2462a81729a3ae69 |
4 |
> > Author: Justin Lecher <jlec <AT> gentoo <DOT> org> |
5 |
> > AuthorDate: Fri Oct 30 10:18:05 2015 +0000 |
6 |
> > Commit: Justin Lecher <jlec <AT> gentoo <DOT> org> |
7 |
> > CommitDate: Fri Oct 30 12:03:49 2015 +0000 |
8 |
> > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df8e399c |
9 |
> > |
10 |
> > eclass: Use consistent place for then in if clause |
11 |
> |
12 |
> Excuse me but who are you exactly to take a random eclass and commit |
13 |
> random style changes inside without even bothering to contact |
14 |
> the author? |
15 |
|
16 |
your attitude is wrong and is a great example of why people in the project |
17 |
are hesitant to touch anything anymore |
18 |
|
19 |
> > Signed-off-by: Justin Lecher <jlec <AT> gentoo.org> |
20 |
> > |
21 |
> > eclass/distutils-r1.eclass | 3 +-- |
22 |
> > 1 file changed, 1 insertion(+), 2 deletions(-) |
23 |
> > |
24 |
> > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass |
25 |
> > index 185dd4f..dbd27a7 100644 |
26 |
> > --- a/eclass/distutils-r1.eclass |
27 |
> > +++ b/eclass/distutils-r1.eclass |
28 |
> > @@ -322,8 +322,7 @@ distutils-r1_python_prepare_all() { |
29 |
> > |
30 |
> > _distutils-r1_disable_ez_setup |
31 |
> > |
32 |
> > - if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]] |
33 |
> > - then |
34 |
> > + if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]]; then |
35 |
> |
36 |
> This was intentionally wrapped to stay within 72-column line width. Not |
37 |
> saying the eclass is perfect in keeping text width, especially with |
38 |
> others committing random changes to it, but that's no reason to |
39 |
> introduce further offenders. |
40 |
|
41 |
Gentoo has never had a hard 80-col rule let alone 72-cols. forcing a wrap |
42 |
here makes no sense and the new version is an improvement. |
43 |
-mike |