Gentoo Archives: gentoo-dev

From: Vlastimil Babka <caster@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] RFC: removal of digest files from the tree
Date: Mon, 28 Jan 2008 08:53:23
Message-Id: 479D9800.5090702@gentoo.org
In Reply to: Re: [gentoo-dev] RFC: removal of digest files from the tree by Chris Gianelloni
1 Chris Gianelloni wrote:
2 > On Sun, 2008-01-27 at 18:01 -0800, Robin H. Johnson wrote:
3 >> On Sun, Jan 27, 2008 at 05:34:14PM -0800, Chris Gianelloni wrote:
4 >>> On Sun, 2008-01-27 at 06:27 -0800, Robin H. Johnson wrote:
5 >>>> Due to how CVS hooks operate, it's not quite possible.
6 >>>> You wouldn't be able to block the entire commit, only the contents of
7 >>>> the files/ directory would get totally blocked.
8 >>>> If you were committing an ebuild along with a patch, this would be very
9 >>>> bad, as the ebuild+Manifest would get committed, but the patch wouldn't.
10 >>> Bleh... CVS vs. SVN. There's no "pre-commit" equivalent on CVS?
11 >> There is pre-commit, but it's not recursive. It gets applied to only a
12 >> single directory and in isolation from the other directories.
13 >
14 > OK. So we could block on commits of digest-* files to files, right?
15 > What else would we need?
16
17 IMHO even if it's possible to selectively block digests and let other
18 FILESDIR stuff (patches) through, it won't remove unneeded
19 files/digest-* entries in Manifest.
20
21 I think we shouldn't overreact to this relatively small problem. If few
22 people commit few digests back, big deal, won't hurt anyone. As
23 betelgeuse said, just make the hook send mail to the dev so he can fix it.
24
25 Caster
26
27 --
28 gentoo-dev@l.g.o mailing list