| 1 |
On Monday 24 September 2007 21:53:14 Donnie Berkholz wrote: |
| 2 |
> > - use video_cards_mga || myconf="${myconf} --disable-mga" |
| 3 |
> > - ( use X && use video_cards_mga ) || myconf="${myconf} --disable-xmga" |
| 4 |
> > + use video_cards_mga && myconf="${myconf} --enable-mga" |
| 5 |
> > + ( use X && use video_cards_mga ) && myconf="${myconf} --enable-xmga" |
| 6 |
> |
| 7 |
> Subshells are gross, can you try a code block { } instead? |
| 8 |
|
| 9 |
A code block isn't even required since this grouping does the same as without |
| 10 |
it. More importantly, though, why isn't this ebuild using use_enable? It |
| 11 |
seems that: |
| 12 |
|
| 13 |
use X && myconf="$myconf $(use_enable video_cards_mga xmga)" |
| 14 |
myconf="$myconf $(use_enable video_cards_mga mga)" |
| 15 |
|
| 16 |
would do the same? |
| 17 |
|
| 18 |
In another example from the ebuild: |
| 19 |
|
| 20 |
> use bl && myconf="${myconf} --enable-bl" |
| 21 |
|
| 22 |
if USE=bl is disabled --disable-bl isn't passed to the configure script which |
| 23 |
means the default is picked. There's a good chance that this kind of |
| 24 |
behaviour results in automagic deps... |
| 25 |
|
| 26 |
http://www.gentoo.org/proj/en/qa/automagic.xml |
| 27 |
|
| 28 |
-- |
| 29 |
Bo Andresen |
Archives