1 |
On Sat, 13 Oct 2018 20:18:06 +0200 |
2 |
Ralph Seichter <gentoo@××××××××.de> wrote: |
3 |
|
4 |
> Glancing at my own open pull requests, it looks different (opened 15 and |
5 |
> 25 days ago, respectively). That is not meant as criticism; it just seems |
6 |
> to me that the team members who process PRs have a lot on their plates. |
7 |
|
8 |
Maybe I can try to explain why your 3 PRs [1] are still opened. |
9 |
|
10 |
The "skel.ebuild" one is easy: global changes have to be discussed on |
11 |
gentoo-dev. That the mailing list was recently whitelisted makes this |
12 |
harder than it should for non-devs. I believe such PRs take us by |
13 |
surprise and we don't have an efficient process for them. Areas for |
14 |
enhancement. |
15 |
|
16 |
The milter-regex one is, I think, a result of miscommunicating intent. |
17 |
zlogene does a great job on PRs by going over nearly all of them to |
18 |
catch obvious style problems. That you corrected them is good, but it |
19 |
doesn't mean that it's going to be merged anytime soon because this |
20 |
package is a net-mail package. Someone from that project [2] is going to |
21 |
have merge it, not zlogene. |
22 |
|
23 |
This is a tricky problem because it's completely understandable that |
24 |
you expect a timely response to your correction, but ultimately, you'll |
25 |
have to nudge someone from the net-mail project. But to know why you |
26 |
don't get a timely response, you need to intimately understand Gentoo's |
27 |
inner dynamics, which you can't. So, you think we rudely ignore you. |
28 |
But we don't, you're just lost in a Kafkaesque maze! |
29 |
|
30 |
Then, we're left with your nginx-unit PR, which is part of the |
31 |
proxy-maint program. Normally, those are well handled. In this case, we |
32 |
have mgorny who doesn't seem to like your PR. Devs tend to trust |
33 |
mgorny's judgement. It doesn't mean that he's right in this instance, |
34 |
but it adds a level of difficulty to the PR. The next dev to review |
35 |
this PR will have to be extra thorough with it if it's going to infirm |
36 |
mgorny's judgement. |
37 |
|
38 |
This places it in the "tricky PRs" mental bucket for, I guess, many |
39 |
proxy-maint members and it means that easier PRs will be processed |
40 |
before it. Sorry, it seems that you picked a tough package to |
41 |
be proxied-maintainer for. |
42 |
|
43 |
As I hope to have demonstrated, there is no ill intent or even |
44 |
negligence in the result that you observe. It's just that our processes |
45 |
are complex and far from perfect, and the workload, significant. In the |
46 |
end, I think, the best thing to do in most cases is to ping a dev after |
47 |
a reasonable timeout. We're mostly well intended and will take steps to |
48 |
minimize frustrations when we're made aware of them. |
49 |
|
50 |
Regards, |
51 |
Virgil |
52 |
|
53 |
[1]: https://github.com/gentoo/gentoo/pulls/rseichter |
54 |
[2]: https://wiki.gentoo.org/wiki/Project:Net-Mail |