[gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in dev-php5/onphp: ChangeLog onphp-0.10.6.ebuild onphp-0.10.4.ebuild onphp-0.10.3.ebuild

[Steve Long]

Thomas de Grenier de Latour wrote:

> On 2007/10/14, Drake Wyrm <wyrm@×××××.com> wrote:
>
>> Or, since you already have the command substitution there, how about:
>>
>> dodoc `find doc -maxdepth 1 -type f`
>
> Or even better, how about explicitly listing the relevant files
> (ChangeLog, AUTHORS, FEATURES, THANKS, README, CodingStyle, TODO and
> FAQ) and avoid the useless ones (Doxyfile, onphp.doxy.php and LICENSE)?
>
> And also, given the kind of files being there, what about moving
> this block out of the "use doc" conditional?
>
The `useless' ones are the ones I would expect to get installed if I set doc
USE flag (apart from LICENSE which already exists on the local machine.)

I agree the others should be installed unconditionally, and it might be
useful to have a standard list that dodoc (or some other fn) checks, eg: 

stdDocs=(ChangeLog AUTHORS FEATURES THANKS README CodingStyle TODO FAQ)

stdDoc() {
        local d l=()
        for d in "${stdDocs[@]}"; do
                [[ -f $d ]] && l+=("$d")
        done
        ((${#l[@]})) && dodoc "${l[@]}"
}

(assuming [[ $PWD = $S ]] or whichever is the right one for docs.)


-- 
gentoo-dev@g.o mailing list