Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: bugfix for get-flag()

[Ulrich Mueller]

>>>>> On Sun, 15 May 2016, rindeal  wrote:

[Looks like your mailer is broken. All the tabs in your patch have
been mangled and appear as spaces.]

> +       # reverse loop
> +       set -- ${!var}
> +       local i=${#}
> +       while [[ ${i} > 0 ]] ; do
> +           local arg="${!i}"

Using the positional parameters looks needlessly complicated here.
Why not use an array, like this (untested):

	local -a flags=(${!var})
	for (( i=${#flags[@]}-1; i>=0; i-- )); do

Below you can use ${flags[i]} instead of ${arg} then.

Ulrich