[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in games-board/gnugo: gnugo-3.9.1-r1.ebuild ChangeLog

[Michael Palimaka]

On 02/06/15 17:04, Michał Górny wrote:
> Dnia 2015-06-02, o godz. 03:58:35
> "Michael Sterrett (mr_bones_)" <mr_bones_@g.o> napisał(a):
>
>> mr_bones_    15/06/02 03:58:35
>>
>>   Modified:             gnugo-3.9.1-r1.ebuild ChangeLog
>>   Log:
>>   add slot dep for repoman
>>
>>   (Portage version: 2.2.18/cvs/Linux x86_64, unsigned Manifest commit)
>>
>> Revision  Changes    Path
>> 1.5                  games-board/gnugo/gnugo-3.9.1-r1.ebuild
>>
>> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/games-board/gnugo/gnugo-3.9.1-r1.ebuild?rev=1.5&view=markup
>> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/games-board/gnugo/gnugo-3.9.1-r1.ebuild?rev=1.5&content-type=text/plain
>> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/games-board/gnugo/gnugo-3.9.1-r1.ebuild?r1=1.4&r2=1.5
>>
>> Index: gnugo-3.9.1-r1.ebuild
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/games-board/gnugo/gnugo-3.9.1-r1.ebuild,v
>> retrieving revision 1.4
>> retrieving revision 1.5
>> diff -u -r1.4 -r1.5
>> --- gnugo-3.9.1-r1.ebuild	25 Mar 2015 13:51:47 -0000	1.4
>> +++ gnugo-3.9.1-r1.ebuild	2 Jun 2015 03:58:35 -0000	1.5
>> @@ -1,6 +1,6 @@
>>  # Copyright 1999-2015 Gentoo Foundation
>>  # Distributed under the terms of the GNU General Public License v2
>> -# $Header: /var/cvsroot/gentoo-x86/games-board/gnugo/gnugo-3.9.1-r1.ebuild,v 1.4 2015/03/25 13:51:47 ago Exp $
>> +# $Header: /var/cvsroot/gentoo-x86/games-board/gnugo/gnugo-3.9.1-r1.ebuild,v 1.5 2015/06/02 03:58:35 mr_bones_ Exp $
>>
>>  EAPI=5
>>  inherit eutils games
>> @@ -14,7 +14,7 @@
>>  KEYWORDS="amd64 ~arm ~ppc ~ppc64 x86 ~amd64-linux ~x86-linux ~ppc-macos"
>>  IUSE="readline"
>>
>> -DEPEND="readline? ( sys-libs/readline )
>> +DEPEND="readline? ( sys-libs/readline:0 )
>>  	>=sys-libs/ncurses-5.2-r3"
>>  RDEPEND=${DEPEND}
>
> This should be actually := (or :0=) for both deps since gnugo links to
> them. This also applies to your remaining 'warning silencing' commits.
>

Why? Blindly adding the subslot dep is a bad idea.