Gentoo Archives: gentoo-dev

From: Justin Lecher <jlec@g.o>
To: gentoo-dev@l.g.o
Cc: wxwidgets@g.o, Justin Lecher <jlec@g.o>
Subject: [gentoo-dev] [PATCH 3/5] wxwidgets.eclass: unset unneeded variables in global scope after usage
Date: Mon, 01 Feb 2016 11:10:54
Message-Id: 1454324913-27584-4-git-send-email-jlec@gentoo.org
In Reply to: [gentoo-dev] [PATCH 0/5] RFC: Patches for wxwidgets.eclass by Justin Lecher
1 Signed-off-by: Justin Lecher <jlec@g.o>
2 ---
3 eclass/wxwidgets.eclass | 13 ++++++++-----
4 1 file changed, 8 insertions(+), 5 deletions(-)
5
6 diff --git a/eclass/wxwidgets.eclass b/eclass/wxwidgets.eclass
7 index bcdeb53..5c0719d 100644
8 --- a/eclass/wxwidgets.eclass
9 +++ b/eclass/wxwidgets.eclass
10 @@ -64,14 +64,14 @@ inherit eutils flag-o-matic multilib
11 # inheriting.
12 if [[ -z ${WX_CONFIG} ]]; then
13 if [[ -n ${WX_GTK_VER} ]]; then
14 - for wxtoolkit in mac gtk2 base; do
15 + for _wxtoolkit in mac gtk2 base; do
16 # newer versions don't have a seperate debug profile
17 - for wxdebug in xxx release- debug-; do
18 - wxconf="${wxtoolkit}-unicode-${wxdebug/xxx/}${WX_GTK_VER}"
19 + for _wxdebug in xxx release- debug-; do
20 + _wxconf="${_wxtoolkit}-unicode-${_wxdebug/xxx/}${WX_GTK_VER}"
21
22 - [[ -f ${EPREFIX}/usr/$(get_libdir)/wx/config/${wxconf} ]] || continue
23 + [[ -f ${EPREFIX}/usr/$(get_libdir)/wx/config/${_wxconf} ]] || continue
24
25 - WX_CONFIG="${EPREFIX}/usr/$(get_libdir)/wx/config/${wxconf}"
26 + WX_CONFIG="${EPREFIX}/usr/$(get_libdir)/wx/config/${_wxconf}"
27 WX_ECLASS_CONFIG="${WX_CONFIG}"
28 break
29 done
30 @@ -80,6 +80,9 @@ if [[ -z ${WX_CONFIG} ]]; then
31 [[ -n ${WX_CONFIG} ]] && export WX_CONFIG WX_ECLASS_CONFIG
32 fi
33 fi
34 +unset _wxtoolkit
35 +unset _wxdebug
36 +unset _wxconf
37
38 # @FUNCTION: need-wxwidgets
39 # @USAGE: <profile>
40 --
41 2.7.0