Gentoo Archives: gentoo-dev

From: "Miroslav Šulc" <fordfrog@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] ant-tasks.eclass patch proposal
Date: Fri, 18 Jan 2019 17:25:17
Message-Id: f67aff2a-35ab-35cd-a85f-9874f6a22ec9@gentoo.org
In Reply to: Re: [gentoo-dev] ant-tasks.eclass patch proposal by Brian Evans
1 thank you for the comments. i added eapi check at the beginning
2 supporting eapi 5|6|7 (5 is needed for current ebuilds). i also changed
3 epatch to eapply and disabled patching build.xml for eapi5 just to make
4 the code more robust, build.xml patching is not used in current ebuilds
5 and those will be soon gone. once they are gone, this check and support
6 for eapi5 can both be removed. attached is the updated patch.
7
8 miroslav
9
10 Dne 18. 01. 19 v 17:23 Brian Evans napsal(a):
11 > On 1/18/2019 11:11 AM, Miroslav Šulc wrote:
12 >> @@ -130,7 +112,11 @@ ant-tasks_src_unpack() {
13 >> cd "${S}"
14 >>
15 >> # replace build.xml with our modified for split building
16 >> - mv -f "${WORKDIR}"/build.xml .
17 >> + if [ -e "${WORKDIR}"/${PV}-build.patch ] ; then
18 >> + epatch "${WORKDIR}"/${PV}-build.patch
19 > Adding epatch without 'inherit epatch'? Sounds like gambling on faith.
20 > Also limits to EAPI=6.
21 >
22 > Brian
23 >
24 >> + else
25 >> + mv -f "${WORKDIR}"/build.xml .
26 >> + fi
27 >>
28 >> cd lib
29 >> # remove bundled xerces

Attachments

File name MIME type
ant-tasks.patch text/x-patch

Replies

Subject Author
Re: [gentoo-dev] ant-tasks.eclass patch proposal "Miroslav Šulc" <fordfrog@g.o>