| 1 |
On Friday 24 November 2006 11:16, Kevin F. Quinn wrote: |
| 2 |
> Although I committed it originally almost a year ago, it hasn't been |
| 3 |
> used yet, so if there's anything fundamentally wrong with whole thing, |
| 4 |
> now is the time say as it can be removed with impunity. |
| 5 |
|
| 6 |
some suggestions: |
| 7 |
|
| 8 |
you should use "$@" rather than $* |
| 9 |
|
| 10 |
looks like every use of ${f} should be quoted |
| 11 |
|
| 12 |
full paths to paxctl/chpax/scanelf seem pretty lame to me, especially since |
| 13 |
not having /sbin and /usr/bin in $PATH while executing portage code would |
| 14 |
never work |
| 15 |
|
| 16 |
use 'type -p prog > /dev/null' rather than '[[ -x /full/path/prog ]]' |
| 17 |
|
| 18 |
host-is-pax() { grep -qs ^PaX: /proc/self/status ; } |
| 19 |
-mike |
Archives