Archives
Archives
| From: | Michael Orlitzky <mjo@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] [PATCH v4 08/19] user.eclass: Factor out finding nologin into separate function | ||
| Date: | Thu, 13 Jun 2019 13:01:26 | ||
| Message-Id: | 6ae45adb-2e3a-df7e-b024-3a471ebd6eba@gentoo.org | ||
| In Reply to: | Re: [gentoo-dev] [PATCH v4 08/19] user.eclass: Factor out finding nologin into separate function by "Michał Górny" |
||
| 1 | On 6/13/19 1:33 AM, Michał Górny wrote: |
| 2 | >> |
| 3 | >>> + eshell=$(user_get_nologin) |
| 4 | >> |
| 5 | >> Then this would have to become |
| 6 | >> |
| 7 | >> eshell=$(userland_get_nologin "${USERLAND}") |
| 8 | > |
| 9 | > Do you have any real use for that? |
| 10 | > |
| 11 | |
| 12 | No. It's a better design IMO since you can e.g. test the function by |
| 13 | passing it an argument rather than by setting a global variable (which |
| 14 | has other consequences). But no immediate application. |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] [PATCH v4 08/19] user.eclass: Factor out finding nologin into separate function | "Michał Górny" <mgorny@g.o> |