| 1 |
On Thursday, June 10, 2010 16:45:29 Arfrever Frehtes Taifersar Arahesis wrote: |
| 2 |
> 2010-06-10 22:20:44 Nirbheek Chauhan napisał(a): |
| 3 |
> > On Fri, Jun 11, 2010 at 1:30 AM, Arfrever Frehtes Taifersar wrote: |
| 4 |
> > > 2010-06-10 21:27:40 Jeremy Olexa napisał(a): |
| 5 |
> > >> I see no reason to *not* add a ChangeLog entry here. |
| 6 |
> > > |
| 7 |
> > > ChangeLog entries are not required for trivial changes. |
| 8 |
> > |
| 9 |
> > A "trivial" change is fixing a typo, or a manifest problem, a missing |
| 10 |
> > quotation mark, etc. Anything else is not "trivial". |
| 11 |
> > |
| 12 |
> > Anything that changes how an ebuild functions, what it does, or the |
| 13 |
> > installed files (and/or their contents) is NOT a trivial change. |
| 14 |
> |
| 15 |
> This commit only removed some compiler warnings. |
| 16 |
|
| 17 |
mucking with CFLAGS without documentation is wrong. compiler warnings come |
| 18 |
and go, so a flag that was relevant one day could be completely extraneous the |
| 19 |
next. |
| 20 |
|
| 21 |
however, especially with strict aliasing, you arent "just fixing warnings", |
| 22 |
you're changing optimization behavior of gcc to workaround broken C code. |
| 23 |
this obviously does not fall anywhere near the "trivial" mark. |
| 24 |
|
| 25 |
i see you still havent fixed this, so get on it already. a bug needs to be |
| 26 |
opened somewhere to get the package properly *fixed*, and your change either |
| 27 |
out right reverted or add a comment around the flag to indicate the open bug |
| 28 |
on the issue. |
| 29 |
append-flags ... #12345 |
| 30 |
-mike |
Archives