| 1 |
On 14-12-2017 14:41:17 +0100, Michał Górny wrote: |
| 2 |
> W dniu czw, 14.12.2017 o godzinie 13∶56 +0100, użytkownik Fabian Groffen |
| 3 |
> napisał: |
| 4 |
> > On 14-12-2017 13:39:18 +0100, Michał Górny wrote: |
| 5 |
> > > Dnia 14 grudnia 2017 13:21:47 CET, Fabian Groffen <grobian@g.o> napisał(a): |
| 6 |
> > > > Can we make it a policy to list /what/ QA issues are the justification |
| 7 |
> > > > for commits like these? A description in the commit message would be |
| 8 |
> > > > preferred, but a pointer to a location where said issues can be found |
| 9 |
> > > > would do too. |
| 10 |
> > > |
| 11 |
> > > Maintainer-needed is reason enough. If somebody couldn't be bothered to maintain what he committed, why should we bother to list the issues? |
| 12 |
> > > |
| 13 |
> > > Using repoman and looking at CI mails is also a good idea. |
| 14 |
> > |
| 15 |
> > Obviously for me to learn something, I won't/can't use repoman here. So |
| 16 |
> > a pointer to said CI mails from the message of the QA commit would be |
| 17 |
> > nice. |
| 18 |
> |
| 19 |
> Last I checked, I wasn't personally responsible for teaching people |
| 20 |
> ebuild writing 101 while on phone. But here you go (in malformed paste |
| 21 |
> of ebuild below). |
| 22 |
|
| 23 |
You simply replied, and therefore took ownership from QA point of view. |
| 24 |
I can't help it you do that whilst on the phone. In fact, this is |
| 25 |
email, so being on the phone is not a good reason to be vague and avoid |
| 26 |
answering questions in the first place. |
| 27 |
|
| 28 |
[snip issues] |
| 29 |
|
| 30 |
Thanks, much appreciated. I'm completely convinced now. I'm referring |
| 31 |
back to my earlier suggestion to include such list or the type of issues |
| 32 |
found when a drastic commit like the one we discuss is done under the QA |
| 33 |
flag. It's good to know that the QA issue complaint was valid, and |
| 34 |
improvements can be made. |
| 35 |
|
| 36 |
A final suggestion is to talk to the committer before taking such |
| 37 |
drastic actions, in a situation where our users aren't endangered. As |
| 38 |
this one is, in my opinion. |
| 39 |
There is more problematic stuff in the tree, but teach a man to fish ... |
| 40 |
next time the problems may be avoided. |
| 41 |
|
| 42 |
Thanks, |
| 43 |
Fabian |
| 44 |
|
| 45 |
-- |
| 46 |
Fabian Groffen |
| 47 |
Gentoo on a different level |
Archives