| 1 |
On 03/06/15 01:30, Mike Frysinger wrote: |
| 2 |
> On 03 Jun 2015 00:28, Michael Palimaka wrote: |
| 3 |
>> On 02/06/15 23:52, Mike Frysinger wrote: |
| 4 |
>>> On 02 Jun 2015 23:07, Michael Palimaka wrote: |
| 5 |
>>>> On 02/06/15 21:38, Mike Frysinger wrote: |
| 6 |
>>>>> On 02 Jun 2015 20:47, Michael Palimaka wrote: |
| 7 |
>>>>>> On 02/06/15 17:04, Michał Górny wrote: |
| 8 |
>>>>>>> Dnia 2015-06-02, o godz. 03:58:35 |
| 9 |
>>>>>>> "Michael Sterrett (mr_bones_)" <mr_bones_@g.o> napisał(a): |
| 10 |
>>>>>>>> -DEPEND="readline? ( sys-libs/readline ) |
| 11 |
>>>>>>>> +DEPEND="readline? ( sys-libs/readline:0 ) |
| 12 |
>>>>>>> |
| 13 |
>>>>>>> This should be actually := (or :0=) for both deps since gnugo links to |
| 14 |
>>>>>>> them. This also applies to your remaining 'warning silencing' commits. |
| 15 |
>>>>>> |
| 16 |
>>>>>> Why? Blindly adding the subslot dep is a bad idea. |
| 17 |
>>>>> |
| 18 |
>>>>> in this particular case, the subslot usage is what we want since we're |
| 19 |
>>>>> compiling+linking against it. using readline:0 vs readline is still an |
| 20 |
>>>>> improvement though. |
| 21 |
>>>>> |
| 22 |
>>>>> we also want a subslot on ncurses since we compile+link against it. |
| 23 |
>>>>> |
| 24 |
>>>>> i think it's pretty uncommon to use readline in a package and not want a |
| 25 |
>>>>> subslot. your package would have to be doing something uncommon like |
| 26 |
>>>>> dlopening it since the only thing readline provides is a library ... |
| 27 |
>>>> |
| 28 |
>>>> Neither readline nor ncurses define an explicit subslot, so I don't know |
| 29 |
>>>> what their future meaning might be. |
| 30 |
>>> |
| 31 |
>>> their meaning would be the reasonable one -- to track the SONAME. while it |
| 32 |
>>> hasn't been deployed yet (due to those packages being on EAPI=4), i don't know |
| 33 |
>>> what other value you'd expect it to be. they've both broken their SONAMEs in |
| 34 |
>>> the past. readline in particular has been every major version (4.x, 5.x, 6.x). |
| 35 |
>> |
| 36 |
>> Since you've clarified the future meaning for ncurses/readline, it's not |
| 37 |
>> a problem. |
| 38 |
>> |
| 39 |
>> The point was it's not a good idea to use the operator unless without |
| 40 |
>> knowing what it means for the package in question (since a subslot can |
| 41 |
>> be used to handle a number of different situations, as I wrote previously). |
| 42 |
> |
| 43 |
> you make a reasonable point, but i'd consider some of your examples as |
| 44 |
> (ab|mis)use of subslots. their purpose is to track ABI changes so as |
| 45 |
> to signal rebuilds. if they've been appropriated for other uses, then |
| 46 |
> perhaps those libraries are doing it wrong ? i expect subslots to do |
| 47 |
> one thing (what PMS describes/intends) and would be surprised to find |
| 48 |
> out that some packages are doing something else. |
| 49 |
> -mike |
| 50 |
> |
| 51 |
|
| 52 |
They're still tracking ABI changes to signal rebuilds - they just don't |
| 53 |
apply to all consumers. poppler's subslot tracks the main libpoppler |
| 54 |
which frequently breaks, but the package also provides libpoppler-qt4 |
| 55 |
which is stable - these consumers never need rebuilding. |
Archives