Gentoo Archives: gentoo-dev

From: Hans de Graaff <graaff@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] eclass/ruby-fakegem.eclass: guard against broken rdoc
Date: Mon, 18 Jul 2022 13:36:19
Message-Id: 3868799b305dd93fee6f80b7b08b5910e0c3d3c9.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] eclass/ruby-fakegem.eclass: guard against broken rdoc by Sam James
1 On Fri, 2022-07-15 at 13:04 +0100, Sam James wrote:
2 >
3 > I worry a bit about silently skipping given it can go further
4 > and lead to e.g. unpredictably broken binpkgs.
5
6 Yes, not really happy with that either, even though this only affects
7 documentation files.
8
9 > I'd probably prefer not doing +doc but I assume it's there
10 > for a reason.
11
12 Your question prompted me to investigate this again. +doc was added
13 initially to ensure that the built-in documentation was generated which
14 people expect to work as part of normal operations. Starting with
15 bundler 2.2.0 this documentation is now bundled as part of the gem and
16 does not need to be generated anymore, so for the 2.2 and 2.3 series
17 the +doc can be dropped.
18
19 I'll drop the patch since I expect that this is no longer needed (or at
20 least, the drawbacks now outweight the benefits.
21
22 Hans

Attachments

File name MIME type
signature.asc application/pgp-signature