| 1 |
Michał Górny posted on Thu, 26 May 2016 14:08:26 +0200 as excerpted: |
| 2 |
|
| 3 |
> @@ -254,6 +269,15 @@ _git-r3_env_setup() { |
| 4 |
> [[ ${!livevar} ]] \ |
| 5 |
> && ewarn "Using ${livevar}, no support will be provided" |
| 6 |
> |
| 7 |
> + livevar=${esc_pn}_LIVE_COMMIT_DATE |
| 8 |
> + EGIT_COMMIT_DATE=${!livevar-${EGIT_COMMIT_DATE}} |
| 9 |
> + [[ ${!livevar} ]] \ |
| 10 |
> + && ewarn "Using ${livevar}, no support will be provided" |
| 11 |
|
| 12 |
I'd guess that for consistency you want this to be the... |
| 13 |
|
| 14 |
if [[...]]; then |
| 15 |
|
| 16 |
... style that seems to be preferred in this eclass, instead of the bare... |
| 17 |
|
| 18 |
[[...]] && |
| 19 |
|
| 20 |
... style used here. |
| 21 |
|
| 22 |
(Tho I personally actually prefer the bare [[...]] && style if there's |
| 23 |
no else clause, if/then/else to make it explicit if there is. But that's |
| 24 |
not what the existing code seems to use, so...) |
| 25 |
|
| 26 |
|
| 27 |
Meanwhile, in general, I love the idea of having commit date access, |
| 28 |
of course with a user override available. I only have a lite kde/plasma |
| 29 |
install, but it's all live-9999 packages from the kde overlay and of course |
| 30 |
they're all git now, in addition to the pan-9999 ebuild in my overlay as |
| 31 |
I'm involved upstream there, so I make a *lot* of use of git-r3 eclass, |
| 32 |
and having date override available will definitely help with the occasional |
| 33 |
troubleshooting or easy revert to a date I know actually worked! =:^) |
| 34 |
|
| 35 |
-- |
| 36 |
Duncan - List replies preferred. No HTML msgs. |
| 37 |
"Every nonfree program has a lord, a master -- |
| 38 |
and if you use the program, he is your master." Richard Stallman |
Archives