| 1 |
Georgi Georgiev wrote: [Fri Nov 12 2004, 02:07:58AM EST] |
| 2 |
> Shouldn't do*, in*, new* die on a failure? |
| 3 |
|
| 4 |
I've flip-flopped on this one. Previously I said that all dies should |
| 5 |
be in the ebuild itself. I even fixed a lot of ebuilds to call die |
| 6 |
after said commands. But I think that's a losing battle. Nowadays I |
| 7 |
agree that it would be easiest and best if econf, emake, do*, new*, |
| 8 |
etc. would die on failure. The simple reason is that there is no |
| 9 |
situation in which one of these commands should fail normally in the |
| 10 |
course of an ebuild. |
| 11 |
|
| 12 |
The problem is that it isn't always possible. Many of the commands |
| 13 |
are implemented as scripts in /usr/lib/portage/bin instead of |
| 14 |
functions so they can be used on the RHS of xargs. |
| 15 |
|
| 16 |
One possibility would be to implement both: (1) functions in ebuild.sh |
| 17 |
that would die automatically and (2) scripts in /usr/lib/portage/bin |
| 18 |
that would operate on the RHS of xargs. You'd lose the ability to die |
| 19 |
automatically in the latter case, but hopefully it's rare enough that |
| 20 |
it wouldn't be a big deal. |
| 21 |
|
| 22 |
Regards, |
| 23 |
Aron |
| 24 |
|
| 25 |
-- |
| 26 |
Aron Griffis |
| 27 |
Gentoo Linux Developer |
Archives