Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: David Michael <fedora.dm0@×××××.com>
Cc: gentoo-dev@l.g.o, floppym@g.o, williamh@g.o
Subject: Re: [gentoo-dev] [PATCH 2/2] meson.eclass: EAPI 8 support
Date: Thu, 24 Jun 2021 16:59:38
Message-Id: uk0mjci6n@gentoo.org
In Reply to: [gentoo-dev] [PATCH 2/2] meson.eclass: EAPI 8 support by David Michael
1 >>>>> On Thu, 24 Jun 2021, David Michael wrote:
2
3 > if [[ -z ${_MESON_ECLASS} ]]; then
4
5 Here would be a good place to assign _MESON_ECLASS=1. It should go
6 _before_ any inherit commands, otherwise it won't prevent circular
7 inherits.
8
9 >
10 > +[[ ${EAPI} == 6 ]] && inherit eapi7-ver
11 > inherit multiprocessing ninja-utils python-utils-r1 toolchain-funcs
12
13 > [...]
14
15 > +_MESON_ECLASS=1
16
17 Too late here.
18
19 > fi

Attachments

File name MIME type
signature.asc application/pgp-signature