Gentoo Archives: gentoo-dev

From: Ryan Hill <dirtyepic@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/eclipse-sdk: eclipse-sdk-3.2.1-r2.ebuild ChangeLog eclipse-sdk-3.3.1.1.ebuild
Date: Tue, 22 Jan 2008 00:23:32
Message-Id: fn3d1a$8oi$1@ger.gmane.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/eclipse-sdk: eclipse-sdk-3.2.1-r2.ebuild ChangeLog eclipse-sdk-3.3.1.1.ebuild by Donnie Berkholz
1 Donnie Berkholz wrote:
2 > On 12:15 Mon 21 Jan , Jean-Noel Rivasseau (elvanor) wrote:
3 >> 1.1 dev-util/eclipse-sdk/eclipse-sdk-3.3.1.1.ebuild
4 >>
5 >> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-util/eclipse-sdk/eclipse-sdk-3.3.1.1.ebuild?rev=1.1&view=markup
6 >> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-util/eclipse-sdk/eclipse-sdk-3.3.1.1.ebuild?rev=1.1&content-type=text/plain
7 >
8 >> src_unpack() {
9 >> unpack "${A}"
10 >> patch-apply
11 >> remove-bundled-stuff
12 >>
13 >> # No warnings / Java 5 / all output should be directed to stdout
14 >> find "${S}" -type f -name '*.xml' -exec \
15 >> sed -r -e "s:(-encoding ISO-8859-1):\1 -nowarn:g" -e "s:(\"compilerArg\" value=\"):\1-nowarn :g" \
16 >> -e "s:(<property name=\"javacSource\" value=)\".*\":\1\"1.5\":g" \
17 >> -e "s:(<property name=\"javacTarget\" value=)\".*\":\1\"1.5\":g" -e "s:output=\".*(txt|log).*\"::g" -i {} \;
18 >
19 > I think this will end up calling sed a large number of times, since
20 > -exec runs per file found instead of once on all files. If you instead
21 > pipe find output to xargs sed, that might work better. Depending on how
22 > many files are involved, this could be a significant difference.
23
24 Better yet, use
25
26 find [...] -print0 | xargs -0 sed -r -e [...] -e [...] -i
27
28 This handles files with special characters like spaces in their names.
29
30
31 --
32 fonts, by design, by neglect
33 gcc-porting, for a fact or just for effect
34 wxwindows @ gentoo EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies