Archives
Archives
| From: | Torsten Veller <ml-en@××××××.net> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Cc: | gentoo-perl@l.g.o | ||
| Subject: | [gentoo-dev] Re: perl-module.eclass -- review - 2 | ||
| Date: | Sat, 28 Feb 2009 11:33:55 | ||
| Message-Id: | 20090228113953.TAb8d40.tv@veller.net | ||
| In Reply to: | [gentoo-dev] perl-module.eclass -- review by Torsten Veller |
||
| 1 | * Torsten Veller <ml-en@××××××.net>: |
| 2 | > Please review the attached perl-module.eclass. |
| 3 | > Patch linked below. |
| 4 | |
| 5 | Thanks Bo Ørsted Andresen for feedback |
| 6 | |
| 7 | > Changes |
| 8 | > ~~~~~~~ |
| 9 | - use emake |
| 10 | - more quoting |
| 11 | - call perlinfo only once |
| 12 | |
| 13 | As I've not seen any ebuild doing the replacement in line 156, |
| 14 | I've added a temporary ewarn. If you hits you, tell me. |
| 15 | |
| 16 | > git://github.com/tove/perl-eclass.git |
| 17 | > http://people.gentoo.org/tove/files/perl-module.eclass.diff |
| File name | MIME type |
|---|---|
| perl-module.eclass | text/plain |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] Re: perl-module.eclass -- review - 2 | Donnie Berkholz <dberkholz@g.o> |