Gentoo Archives: gentoo-dev

From: Andrew Savchenko <bircoph@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] cmake-utils.eclass: two improvements
Date: Sun, 26 Jul 2015 22:27:08
Message-Id: 20150727012635.f5c2e309ac0d8fd7790c3c5a@gentoo.org
In Reply to: Re: [gentoo-dev] cmake-utils.eclass: two improvements by "Vadim A. Misbakh-Soloviov"
1 On Sun, 26 Jul 2015 17:54:52 +0600 Vadim A. Misbakh-Soloviov wrote:
2 > It is bad way to just disable RPATH in eclass without any "buttons" to enable
3 > it back. Moreover, it is bad to disable it even with such "buttons". THe right
4 > way would be to detect if portage instance calling eclass is in PREFIX and
5 > depends on that — keep it or disable.
6
7 This is exactly what proposed patch is doing: it checks if EPREFIX
8 is empty, and only in such case disables RPATH, otherwise it is
9 enabled.
10
11 Best regards,
12 Andrew Savchenko

Replies

Subject Author
Re: [gentoo-dev] cmake-utils.eclass: two improvements William Hubbs <williamh@g.o>