[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/nxserver-freenx: nxserver-freenx-0.7.0-r1.ebuild ChangeLog nxserver-freenx-0.7.1.ebuild

[Bernard Cafarelli]

Le Wed, 31 Oct 2007 16:42:35 -0700
Donnie Berkholz <dberkholz@g.o> a écrit:

> On 19:49 Wed 31 Oct     , Bernard Cafarelli (voyageur) wrote:
> > 1.1                  net-misc/nxserver-freenx/nxserver-freenx-0.7.1.ebuild
> >
> > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/nxserver-freenx/nxserver-freenx-0.7.1.ebuild?rev=1.1&view=markup
> > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/nxserver-freenx/nxserver-freenx-0.7.1.ebuild?rev=1.1&content-type=text/plain
>
> > pkg_postinst () {
> > 	usermod -s /usr/bin/nxserver nx || die "Unable to set login shell of nx user!!"
> > 	usermod -d ${NX_HOME_DIR} nx || die "Unable to set home directory of nx user!!"
>
> This isn't safe with ROOT != / and it looks wrong too, you oughta be
> using enewuser for this stuff.
>
> Thanks,
> Donnie
>

The problem is, enewuser can not be used to modify already existing user
accounts.This happens if another nxserver was installed before (which
uses the same account, but with different shell and home directory). 

I'll fix ROOT handling in the meantime, this should be better:
usermod -s "${ROOT}"/usr/bin/nxserver nx
usermod -d "${ROOT}"{NX_HOME_DIR} nx

Thanks,
-- 
Bernard Cafarelli (Voyageur)
NX and GNUstep Gentoo developer
-- 
gentoo-dev@g.o mailing list