| 1 |
> On 27 Nov 2021, at 09:54, Miroslav Šulc <fordfrog@g.o> wrote: |
| 2 |
> |
| 3 |
> hello devs, |
| 4 |
> |
| 5 |
> please find attached patch for upgrade of java-vm-2.eclass to support eapi 8. eapi 5 is not used by any package inheriting this eclass so i dropped it. |
| 6 |
> |
| 7 |
> i also attach update of the ebuilds of packages that use this eclass and can be updated to eapi 8 (dev-java/icedtea can't atm, it also inherits another java eclass that does not support eapi 8 yet, and dev-java/gcj-jdk is masked in profiles/releases/17.0/package.mask). all works fine except dev-java/openjdk (all slots) where the configuration phase fails or does not finish correctly. all those packages merge fine with eapi 6 (in-tree ebuilds). |
| 8 |
> |
| 9 |
> openjdk:8 - configuration finishes but no configuration file is created (and hence compilation fails) as during the configuration phase it complains with this: |
| 10 |
> configure: error: Could not find freetype! |
| 11 |
> |
| 12 |
> openjdk:11 and openjdk:17 - configuration fails with this error (i was told by sam it is a known bug): |
| 13 |
> configure: error: unrecognized options: --disable-static |
| 14 |
> |
| 15 |
|
| 16 |
When b.g.o is back, let's make sure we update the existing bug about it / file a new one. |
| 17 |
|
| 18 |
> i'd like to merge the patches asap (except the broken openjdk) so please let me know if you find anything that could be improved or all's ok. |
| 19 |
> |
| 20 |
|
| 21 |
lgtm. I'd send with git send-email in future to ease review. |
| 22 |
|
| 23 |
I don't see a point in nitpicking the Java eclasses right now, especially as we might be looking at future improvements anyway for how we handle deps. |
| 24 |
|
| 25 |
Thanks for doing this! |
| 26 |
|
| 27 |
Best, |
| 28 |
sam |
Archives