Gentoo Archives: gentoo-dev

From: Martin Vaeth <martin@×××××.de>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: [PATCH] readme.gentoo-r1.eclass: Do not inherit eutils.
Date: Sat, 19 Dec 2015 18:06:12
Message-Id: n546a1$1ok$1@ger.gmane.org
In Reply to: Re: [gentoo-dev] [PATCH] readme.gentoo-r1.eclass: Do not inherit eutils. by "Michał Górny"
1 Michał Górny <mgorny@g.o> wrote:
2 >> if [[ -n "${DISABLE_AUTOFORMATTING}" ]]; then
3 >> echo "${DOC_CONTENTS}" > "${T}"/README.gentoo || die
4 >> else
5 >> echo -e ${DOC_CONTENTS} | fold -s -w 70 \
6 >> | sed 's/[[:space:]]*$//' > "${T}"/README.gentoo
7
8 (omitted some lines/space for better context):
9
10 > Maybe I'm missing something but is there any reason not to quote
11 > "${DOC_CONTENTS}" instead of working around the results of not quoting
12 > it?
13
14 With DISABLE_AUTOFORMATTING=true, it is correctly quoted,
15 and there is no "workaround".
16 Without DISABLE_AUTOFORMATTING, the autowrapping (and ignoring
17 of "manual" format information by not quoting) is obviously
18 intentional.
19 Maybe, it would be more natural to have the opposite as the default,
20 but this is how the eclass works from its very beginning.