1 |
On Sun, Oct 2, 2016 at 1:28 PM, konsolebox <konsolebox@×××××.com> wrote: |
2 |
> On Sun, Oct 2, 2016 at 12:34 AM, Dan Douglas <ormaaj@×××××.com> wrote: |
3 |
>> I'd be perfectly happy requiring bundled readline when USE="readline" |
4 |
>> for bash versions incompatible with the installed readline, |
5 |
> |
6 |
> I guess that's another good way to solve the readline issue (when it |
7 |
> comes to bash). But I'd prefer that it's not done automatically. |
8 |
> Instead we should add a formal use flag like 'installed-readline'. We |
9 |
> can add it to release versions of bash ([[ ${PV} != *_rc* ]] && |
10 |
> IUSE+=' +installed-readline'), and enable it by default. Then we |
11 |
> change all `[[ ${PV} != *_rc* ]]` condition checks to `[[ ${PV} != |
12 |
> *_rc* ]] && use installed-readline`. `${PV} != *_rc*` probably should |
13 |
> also be `${PV} != *_alpha* && ${PV} != *_beta* && ${PV} != *_rc*`. |
14 |
> (See attached file for POC.) |
15 |
|
16 |
I missed disabling the dependency to readline when |
17 |
'installed-readline' is disabled. Here's another example. |
18 |
|
19 |
I also fixed a repoman warning related to tinfo and renamed |
20 |
'installed_readline' to 'installed-readline'. |
21 |
|
22 |
It installs and runs well with `USE='-installed-readline tinfo' emerge |
23 |
-v 'bash::local'`. |
24 |
|
25 |
The modifications related to tinfo by the way is related to this: |
26 |
https://bugs.gentoo.org/show_bug.cgi?id=588486. I can't install bash |
27 |
properly without it. |
28 |
|
29 |
-- |
30 |
konsolebox |