Gentoo Archives: gentoo-dev

From: Stephan Hartmann <sultan@g.o>
To: gentoo-dev@l.g.o, Mike Gilbert <floppym@g.o>
Cc: base-system@g.o
Subject: Re: [gentoo-dev] [PATCH] unpacker.eclass: enable EAPI 8
Date: Thu, 26 Aug 2021 18:18:37
Message-Id: 055d8566-d103-6c67-ca85-d7503e9db0fb@googlemail.com
In Reply to: Re: [gentoo-dev] [PATCH] unpacker.eclass: enable EAPI 8 by Mike Gilbert
1 On 8/26/21 5:43 PM, Mike Gilbert wrote:
2 > On Thu, Aug 26, 2021 at 7:40 AM Ulrich Mueller <ulm@g.o> wrote:
3 >>
4 >>>>>>> On Thu, 26 Aug 2021, Stephan Hartmann wrote:
5 >>
6 >>> --- a/eclass/unpacker.eclass
7 >>> +++ b/eclass/unpacker.eclass
8 >>> @@ -4,7 +4,7 @@
9 >>> # @ECLASS: unpacker.eclass
10 >>> # @MAINTAINER:
11 >>> # base-system@g.o
12 >>> -# @SUPPORTED_EAPIS: 5 6 7
13 >>> +# @SUPPORTED_EAPIS: 5 6 7 8
14 >>> # @BLURB: helpers for extraneous file formats and consistent behavior across EAPIs
15 >>> # @DESCRIPTION:
16 >>> # Some extraneous file formats are not part of PMS, or are only in certain
17 >>> @@ -16,7 +16,7 @@
18 >>> # - support partial unpacks?
19 >>>
20 >>> case ${EAPI:-0} in
21 >>> - [567]) ;;
22 >>> + [5678]) ;;
23 >>> *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
24 >>> esac
25 >>>
26 >>
27 >> I think for EAPI 8 you'll need additional cases in _unpacker() for
28 >> 7z, .rar, and .lha/.lzh, because package manager support for these
29 >> extensions has been dropped:
30 >> https://projects.gentoo.org/pms/8/pms.html#x1-135002r24
31 >
32 > That would be a nice enhancement for the eclass, but I don't think it
33 > needs to be implemented before EAPI 8 is allowed. It could wait until
34 > some EAPI 8 ebuild actually needs to unpack one of these obscure
35 > formats.
36 >
37 Almost implemented, just need some runtime testing. Will sent an updated
38 patch tomorrow.