Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 2/5] multibuild.eclass: Provide run_in_build_dir from out-of-source-utils
Date: Sun, 01 Jan 2023 16:00:25
Message-Id: 20230101155955.965158-2-mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/5] out-of-source-utils.eclass: New utility eclass by "Michał Górny"
1 Remove the duplicate definition of run_in_build_dir() function
2 and inherit out-of-source-utils to retain it for compatibility with
3 the existing ebuilds in EAPIs 6, 7 and 8. In future EAPIs, the ebuilds
4 needing it will inherit out-of-source-utils directly.
5
6 Signed-off-by: Michał Górny <mgorny@g.o>
7 ---
8 eclass/multibuild.eclass | 25 ++++---------------------
9 1 file changed, 4 insertions(+), 21 deletions(-)
10
11 diff --git a/eclass/multibuild.eclass b/eclass/multibuild.eclass
12 index 7ae03adbe18c..37d6ff104f2e 100644
13 --- a/eclass/multibuild.eclass
14 +++ b/eclass/multibuild.eclass
15 @@ -14,7 +14,10 @@
16 # implementations).
17
18 case ${EAPI} in
19 - 6|7|8) ;;
20 + 6|7|8)
21 + # backwards compatibility for run_in_build_dir
22 + inherit out-of-source-utils
23 + ;;
24 *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
25 esac
26
27 @@ -175,26 +178,6 @@ multibuild_copy_sources() {
28 multibuild_foreach_variant _multibuild_create_source_copy
29 }
30
31 -# @FUNCTION: run_in_build_dir
32 -# @USAGE: <argv>...
33 -# @DESCRIPTION:
34 -# Run the given command in the directory pointed by BUILD_DIR.
35 -run_in_build_dir() {
36 - debug-print-function ${FUNCNAME} "${@}"
37 - local ret
38 -
39 - [[ ${#} -ne 0 ]] || die "${FUNCNAME}: no command specified."
40 - [[ ${BUILD_DIR} ]] || die "${FUNCNAME}: BUILD_DIR not set."
41 -
42 - mkdir -p "${BUILD_DIR}" || die
43 - pushd "${BUILD_DIR}" >/dev/null || die
44 - "${@}"
45 - ret=${?}
46 - popd >/dev/null || die
47 -
48 - return ${ret}
49 -}
50 -
51 # @FUNCTION: multibuild_merge_root
52 # @USAGE: <src-root> <dest-root>
53 # @DESCRIPTION:
54 --
55 2.39.0