Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: William Hubbs <williamh@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 1/3] lua-single.eclass: clean up the eapi test
Date: Fri, 02 Jul 2021 17:46:32
Message-Id: uwnq84nip@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/3] lua-single.eclass: clean up the eapi test by William Hubbs
1 >>>>> On Fri, 02 Jul 2021, William Hubbs wrote:
2
3 > case ${EAPI:-0} in
4
5 This could be just ${EAPI}.
6
7 > - 0|1|2|3|4|5|6)
8 > - die "Unsupported EAPI=${EAPI} (too old) for ${ECLASS}"
9 > - ;;
10 > 7|8)
11 > ;;
12 > *)
13 > - die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
14 > + die "Unsupported EAPI=${EAPI} for ${ECLASS}"
15 > ;;
16
17 May I suggest that we standardise the error message? Many eclasses have
18 this (see for example toolchain-funcs.eclass):
19
20 *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
21
22 > esac
23
24 Same for the other two eclasses.
25
26 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature